Wait for target to be prepared before returning diagnostics#1355
Merged
ahoppen merged 1 commit intoswiftlang:mainfrom May 28, 2024
Merged
Wait for target to be prepared before returning diagnostics#1355ahoppen merged 1 commit intoswiftlang:mainfrom
ahoppen merged 1 commit intoswiftlang:mainfrom
Conversation
Member
Author
|
@swift-ci Please test |
ahoppen
force-pushed
the
wait-for-preparation-before-diags
branch
from
6eb47d3 to
d18e1b7
Compare
Member
Author
|
@swift-ci Please test |
Diagnostics are usually not helpful if the file’s target hasn’t been prepared yet. We should await the target’s preparation before returning diagnostics. rdar://128645617
ahoppen
force-pushed
the
wait-for-preparation-before-diags
branch
from
d18e1b7 to
05dd102
Compare
Member
Author
|
@swift-ci Please test |
Member
Author
|
@swift-ci Please test Windows |
hamishknight
approved these changes
May 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diagnostics are usually not helpful if the file’s target hasn’t been prepared yet. We should await the target’s preparation before returning diagnostics.
rdar://128645617